-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unittests: some fixes to fib_sr tests #4524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProTip: append |
What does it do? |
and it makes no difference if you use |
changes are sane. Without this patch the |
and GO |
cgundogan
added a commit
that referenced
this pull request
Jan 4, 2016
unittests: some fixes to fib_sr tests
@authmillenon, reminder: please backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix #4513, but it makes debugging it a lot easier by correcting the usage of embunit: an assert inside a helper function will cause the helper function to return but not finish the test, leading to very confusing outputs. This minimizes the output of the errors given in #4513 to only one error and I was able to give the analysis I gave there. Additionally, this fixes a lot of the broken formatting in the tests.