Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests: some fixes to fib_sr tests #4524

Merged
merged 2 commits into from
Jan 4, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Dec 19, 2015

This does not fix #4513, but it makes debugging it a lot easier by correcting the usage of embunit: an assert inside a helper function will cause the helper function to return but not finish the test, leading to very confusing outputs. This minimizes the output of the errors given in #4513 to only one error and I was able to give the analysis I gave there. Additionally, this fixes a lot of the broken formatting in the tests.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework labels Dec 19, 2015
@miri64 miri64 added this to the Release 2015.12 milestone Dec 19, 2015
@OlegHahm
Copy link
Member

ProTip: append ?w=0 to the URL for an easier review.

@miri64
Copy link
Member Author

miri64 commented Dec 21, 2015

What does it do?

@cgundogan
Copy link
Member

git diff --help
       -w, --ignore-all-space
           Ignore whitespace when comparing lines. This ignores differences even if one line has whitespace where the other line has none.

and it makes no difference if you use ?w=0 or ?w=1. I personally prefer ?w=1

@cgundogan cgundogan added Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 4, 2016
@cgundogan
Copy link
Member

changes are sane. Without this patch the fib_sr unittest fails because of a wrong usage of embunit. With this patch, the unittest still fails, but unrelated to the changes given here. ACK

@cgundogan
Copy link
Member

and GO

cgundogan added a commit that referenced this pull request Jan 4, 2016
unittests: some fixes to fib_sr tests
@cgundogan cgundogan merged commit 9d18b4e into RIOT-OS:master Jan 4, 2016
@cgundogan
Copy link
Member

@authmillenon, reminder: please backport

@miri64 miri64 deleted the unittests/fix/sr_fib branch January 6, 2016 13:28
@cgundogan cgundogan removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fib_sr: unittests for fib_sr fail sporadically
4 participants