cpu: native: fix native timer_set_absolute() #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
the
Type: bug
|
Might fix #4513. |
34 tasks
|
With this fix I was able to run the unittests @kaspar030 could you also provide a backport to the release branch? |
cgundogan
added
the
Process: needs backport
|
verified. |
miri64
added
the
CI: ready for build
|
ACK and go, when travis is green. |
This was referenced Jan 6, 2016
|
NHDP issue is fixed in #4591. |
kaspar030
added
the
State: waiting for other PR
kaspar030
force-pushed
the
fix_native_timer_set_absolute
branch
from
efa2f6c to
d305643
Compare
|
cgundogan
removed
State: waiting for other PR
|
|
||
| int main(void) | ||
| { | ||
| unsigned n = ITERATIONS; |
There was a problem hiding this comment.
ITERATIONS is greater than 2 << 16 (which is relevant since unsigned is uint16_t on MSP-430 and AVR ;-))
|
ACK and GO as soon as @kaspar030 addressed @authmillenon's comment and travis shows green |
kaspar030
force-pushed
the
fix_native_timer_set_absolute
branch
from
d305643 to
781ee87
Compare
|
|
Travis is green - GO |
cgundogan
added a commit
that referenced
this pull request
Jan 7, 2016
cpu: native: fix native timer_set_absolute()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3344 I introduced a safeguard for native's indeterministic timers which would cause a timer with a very close absolute target time to be triggered at once in order to prevent an underflow.
Turned out that xtimer triggers this safeguard when 1. initializing the timer (setting it to 0), 2. setting an absolute target of 0xFFFFFFFF for its overflow, causing the first overflow to occur 2^32 usec too early.