gnrc_sock: actually bind implicitly #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
Merged
OlegHahm
reviewed
Oct 30, 2016
| @@ -221,11 +221,18 @@ ssize_t sock_udp_send(sock_udp_t *sock, const void *data, size_t len, | |||
| if (sock != NULL) { | |||
| /* bind sock object implicitly */ | |||
| sock->local.port = src_port; | |||
| if (remote == NULL) { | |||
| sock->local.family = sock->remote.family; | |||
There was a problem hiding this comment.
Is it guaranteed that the remote member of the sock struct is always set?
There was a problem hiding this comment.
Yes. The line I just added a minor bugfix above guarantees that either remote != NULL or sock->remote.family != AF_UNSEC.
OlegHahm
approved these changes
Oct 30, 2016
OlegHahm
added
the
CI: ready for build
|
Piggy-backed a minor logical error (which except for some corner cases shouldn't change anything, since in most cases when |
|
ACK upholds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just setting the port won't cut it. ;-). This fixes the issue we encountered in #6020