Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: mutex_order: updated test and fixed README #6051

Merged
merged 3 commits into from
Nov 4, 2016
Merged

tests: mutex_order: updated test and fixed README #6051

merged 3 commits into from
Nov 4, 2016

Conversation

OlegHahm
Copy link
Member

@OlegHahm OlegHahm commented Nov 3, 2016

The README of this test is incorrect. Furthermore, the test includes an unnecessary dependency to xtimer. As a bonus feature this PR also includes an according pexpect script for this test.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 3, 2016
@OlegHahm OlegHahm added this to the Release 2016.10 milestone Nov 3, 2016
@OlegHahm OlegHahm mentioned this pull request Nov 3, 2016
Closed
59 tasks
miri64
miri64 approved these changes Nov 3, 2016
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

tests/mutex_order/tests/01-run.py
4: 4,
5: 0,
6: 2,
7: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To dependend on the C code IMHO, but let's get this merged ASAP.

@miri64
Copy link
Member

miri64 commented Nov 3, 2016

I would recommend to only provide a backport after #6050 was merged so you don't have to rebase ;-)

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 3, 2016
@A-Paul
Copy link
Member

A-Paul commented Nov 3, 2016

Output and README.md correlate now. The python script isn't very helpful as it is. A statement "SUCCESS/FAILED" is missing. Also, make test doesn't exist.
But that's not an error and can be improved later.

@miri64
Copy link
Member

miri64 commented Nov 3, 2016

@A-Paul pexpect fails with an exception if the output is wrong, so you definitely will notice ;-)

@miri64
Copy link
Member

miri64 commented Nov 4, 2016

Murdock fail due to #6036. Go.

@miri64 miri64 merged commit 815426b into RIOT-OS:master Nov 4, 2016
@miri64
Copy link
Member

miri64 commented Nov 4, 2016

Please provide a backport, I want to have an RC tomorrow morning (preferably with this and a backport of #6053).

@A-Paul
Copy link
Member

A-Paul commented Nov 4, 2016

@A-Paul pexpect fails with an exception if the output is wrong, so you definitely will notice ;-)

For a moment I was really afraid that you are serious about that.

This was referenced Nov 4, 2016
Closed
Merged
@miri64 miri64 mentioned this pull request Nov 4, 2016
Closed
@miri64
Copy link
Member

miri64 commented Nov 4, 2016 •
edited
Loading

Backport provided in #6059 #6058

@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Nov 4, 2016
@OlegHahm OlegHahm deleted the fix_test_mutex_order_readme branch November 4, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@haukepetersen haukepetersen

@miri64 miri64

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.
4 participants
@OlegHahm @miri64 @A-Paul @haukepetersen