Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/drivers: remove deprecated lm75a+lpc2387 I2C drivers #6521

Merged
merged 2 commits into from
Feb 7, 2017
Merged

cpu/drivers: remove deprecated lm75a+lpc2387 I2C drivers #6521

merged 2 commits into from
Feb 7, 2017

Conversation

haukepetersen
Copy link
Contributor

@haukepetersen haukepetersen commented Jan 30, 2017 •
edited
Loading

All code removed with this PR is in very bad shape and is not used anywhere (and you can't even use it by simply adding the lm75a module)...

The I2C functionality for the lpc2387 will be re-added with the remodeling of the periph I2C driver (-> #4926). The lm75a driver would need to be ported to the periph_i2c interface to be useful, but I neither have the time nor a device for testing. So I simply mark this PR as memo.

Fixes #4694

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: archived State: The PR has been archived for possible future re-adaptation labels Jan 30, 2017
@haukepetersen haukepetersen added this to the Release 2017.04 milestone Jan 30, 2017
@LudwigKnuepfer
Copy link
Member

I have some lm75a breakout boards.

@LudwigKnuepfer
Copy link
Member

ACK btw.

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 7, 2017
miri64
miri64 approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy-ACK for @LudwigKnuepfer

@miri64 miri64 merged commit 2ef1f2e into RIOT-OS:master Feb 7, 2017
@haukepetersen haukepetersen deleted the rm_lpc_i2clma branch February 8, 2017 09:54
@benpicco benpicco mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@OlegHahm OlegHahm

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: archived State: The PR has been archived for possible future re-adaptation Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.04
Development

Successfully merging this pull request may close these issues.
4 participants
@haukepetersen @LudwigKnuepfer @miri64 @OlegHahm