Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doxygen: fall back to lesscpy if lessc is not found #7607

Merged
merged 1 commit into from
Sep 29, 2017
Merged

doxygen: fall back to lesscpy if lessc is not found #7607

merged 1 commit into from
Sep 29, 2017

Conversation

jnohlgard
Copy link
Member

  • Searches for lesscpy if lessc is not installed. (https://github.com/lesscpy/lesscpy)
  • Changed which to command -v, avoids messages like which: no lessc in (/bin:/usr/bin:...[long path list])
  • Removed @ for documentation commands, lets us see which command is invoked when make runs the preprocessing stages

@jnohlgard jnohlgard added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: doc Area: Documentation labels Sep 15, 2017
@jnohlgard jnohlgard added this to the Release 2017.10 milestone Sep 15, 2017
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 15, 2017
@jnohlgard jnohlgard changed the title Pr/doxygen lesscpy doxygen: fall back to lesscpy if lessc is not found Sep 15, 2017
@miri64
Copy link
Member

miri64 commented Sep 23, 2017

Removed @ for documentation commands, lets us see which command is invoked when make runs the preprocessing stages

Why?

@jnohlgard
Copy link
Member Author

@miri64 I thought it was useful to see the commands, and it doesn't spam the terminal since it is only 3 lines, but I realize that this does not belong in this PR.

@jnohlgard
Copy link
Member Author

@miri64 removed the extra commit, it belongs in a separate PR.

miri64
miri64 approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. ACK

@miri64 miri64 merged commit 9da2c4c into RIOT-OS:master Sep 29, 2017
@jnohlgard jnohlgard deleted the pr/doxygen-lesscpy branch October 11, 2017 04:51
@cladmi cladmi mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jnohlgard @miri64