drivers/tsl2561: apply unified params definition scheme + cleanup #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
aabadie
changed the title
47 tasks
aabadie
added
TF: I2C
aabadie
force-pushed
the
pr/drivers/params/tsl2561
branch
from
ead0c01 to
b4e24c4
Compare
aabadie
force-pushed
the
pr/drivers/params/tsl2561
branch
from
b4e24c4 to
33d4182
Compare
aabadie
force-pushed
the
pr/drivers/params/tsl2561
branch
from
33d4182 to
12460d4
Compare
smlng
reviewed
Jun 28, 2018
| @@ -28,42 +28,44 @@ | |||
| /** | |||
| * @brief Define the number of configured sensors | |||
| */ | |||
| #define TSL2561_NUMOF (sizeof(tsl2561_params) / sizeof(tsl2561_params[0])) | |||
| #define TSL2561_NUM (sizeof(tsl2561_params) / sizeof(tsl2561_params[0])) | |||
There was a problem hiding this comment.
why this renaming? Its I2C_NUMOF, too?
aabadie
force-pushed
the
pr/drivers/params/tsl2561
branch
from
12460d4 to
a751807
Compare
|
tested on pba-d-01-kw2x, works! |
|
@MichelRottleuthner care to approve and merge then? |
|
@aabadie do you want to squash the param/i2c changes into separate commits? |
|
@MichelRottleuthner, for me the history of commits is ok in this PR. It can be merged as is. |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/tsl2561: apply unified params definition scheme + cleanup
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/tsl2561: apply unified params definition scheme + cleanup
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/tsl2561: apply unified params definition scheme + cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR update the params definitions scheme for the tsl2561 device driver.
Issues/PRs references
Initially done in #7937 and related to #7519
#6577