-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/lsm303dlhc: apply unified driver params scheme + cleanup #8699
Merged
dylad
merged 4 commits into
RIOT-OS:new_i2c_if
from
aabadie:pr/drivers/params/lsm303dlhc
Jul 9, 2018
Merged
drivers/lsm303dlhc: apply unified driver params scheme + cleanup #8699
dylad
merged 4 commits into
RIOT-OS:new_i2c_if
from
aabadie:pr/drivers/params/lsm303dlhc
Jul 9, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Process: API change
Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Area: drivers
Area: Device drivers
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Feb 28, 2018
Just tested on iotlab-m3 (not on iotlab), works |
kYc0o
approved these changes
May 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I think it would be better to squash everything in a commit, since the API change commit it's enough to break quite some stuff.
47 tasks
aabadie
removed
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
May 27, 2018
aabadie
force-pushed
the
pr/drivers/params/lsm303dlhc
branch
from
May 27, 2018 20:57
664d8b3
to
6de7017
Compare
aabadie
added
the
TF: I2C
Marks issues and PRs related to the work of the I²C rework task force
label
May 27, 2018
aabadie
force-pushed
the
pr/drivers/params/lsm303dlhc
branch
from
June 7, 2018 21:41
fd93641
to
e75c837
Compare
aabadie
force-pushed
the
pr/drivers/params/lsm303dlhc
branch
from
June 18, 2018 11:32
e75c837
to
69ba59b
Compare
Can someone test it on a second CPU arch so we can push the big green button ? |
Here we go ! |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
…dlhc drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad
added a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
…dlhc drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad
added a commit
that referenced
this pull request
Jul 11, 2018
drivers/lsm303dlhc: apply unified driver params scheme + cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: drivers
Area: Device drivers
Process: API change
Integration Process: PR contains or issue proposes an API change. Should be handled with care.
TF: I2C
Marks issues and PRs related to the work of the I²C rework task force
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates the params definitions scheme and makes some cleanup in the internal driver implementation.
Issues/PRs references
Initially done in #7937 and related to #7519
#6577