Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/lsm303dlhc: apply unified driver params scheme + cleanup #8699

Merged
merged 4 commits into from
Jul 9, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 28, 2018

Contribution description

This PR updates the params definitions scheme and makes some cleanup in the internal driver implementation.

Issues/PRs references

Initially done in #7937 and related to #7519

#6577

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2018
@aabadie
Copy link
Contributor Author

aabadie commented Apr 11, 2018

Just tested on iotlab-m3 (not on iotlab), works

Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I think it would be better to squash everything in a commit, since the API change commit it's enough to break quite some stuff.

@aabadie aabadie removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 27, 2018
@aabadie aabadie force-pushed the pr/drivers/params/lsm303dlhc branch from 664d8b3 to 6de7017 Compare May 27, 2018 20:57
@aabadie aabadie changed the base branch from master to new_i2c_if May 27, 2018 20:57
@aabadie aabadie added the TF: I2C Marks issues and PRs related to the work of the I²C rework task force label May 27, 2018
@aabadie aabadie force-pushed the pr/drivers/params/lsm303dlhc branch from fd93641 to e75c837 Compare June 7, 2018 21:41
@aabadie aabadie force-pushed the pr/drivers/params/lsm303dlhc branch from e75c837 to 69ba59b Compare June 18, 2018 11:32
@dylad
Copy link
Member

dylad commented Jun 27, 2018

Can someone test it on a second CPU arch so we can push the big green button ?

@dylad
Copy link
Member

dylad commented Jul 9, 2018

Here we go !

@dylad dylad merged commit a95e9c5 into RIOT-OS:new_i2c_if Jul 9, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
…dlhc

drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad added a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
…dlhc

drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad added a commit that referenced this pull request Jul 11, 2018
drivers/lsm303dlhc: apply unified driver params scheme + cleanup
@aabadie aabadie deleted the pr/drivers/params/lsm303dlhc branch September 23, 2018 08:47
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. TF: I2C Marks issues and PRs related to the work of the I²C rework task force Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants