Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/cc2420: apply unified driver params scheme #8701

Merged
merged 1 commit into from
Mar 21, 2018
Merged

drivers/cc2420: apply unified driver params scheme #8701

merged 1 commit into from
Mar 21, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 28, 2018

Contribution description

This PR updates the params definitions scheme of this device driver

Issues/PRs references

Initially done in #7937 and related to #7519

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2018
This was referenced Mar 1, 2018
Merged
Merged
@aabadie aabadie force-pushed the pr/drivers/params/cc2420 branch from 97ce6b4 to eb81eae Compare March 1, 2018 13:30
miri64
miri64 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, this just changes a macro name (and makes the macro configurable) and removes the usage of an undefined macro => can be trusted to be merged with just compile tests.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2018
miri64
miri64 requested changes Mar 7, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some CC2420_PARAMS_BOARD in the code, so this needs proper testing.

@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 8, 2018
@miri64
Copy link
Member

miri64 commented Mar 8, 2018

Depends on #8706 and #8707.

miri64
miri64 approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more CC2420_PARAMS_BOARD in master => can be merged now.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 15, 2018
@aabadie
Copy link
Contributor Author

aabadie commented Mar 21, 2018

All green there, merging

@aabadie aabadie merged commit 0f07bcc into RIOT-OS:master Mar 21, 2018
@aabadie aabadie deleted the pr/drivers/params/cc2420 branch June 8, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@kYc0o kYc0o

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @miri64 @kYc0o