Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/samr21-xpro: fix driver params usage #8703

Merged
merged 1 commit into from
Mar 8, 2018
Merged

boards/samr21-xpro: fix driver params usage #8703

merged 1 commit into from
Mar 8, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 28, 2018

Contribution description

This PR fixes the radio driver params definitions in samr21-xpro.

Issues/PRs references

Initially done in #7937, related to #7519 and should be based on #8700

@aabadie aabadie added Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2018
@smlng smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 5, 2018
@aabadie aabadie mentioned this pull request Mar 7, 2018
Merged
miri64
miri64 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Was able to communicate and set states (and feel their effects) using gnrc_networking.

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 8, 2018
@miri64
Copy link
Member

miri64 commented Mar 8, 2018

After looking at #8700 I argue that it is more the other way around: #8700 is based on this PR, since without the changes here #8700 breaks behavior for all at86rf2xx-shipped radios.

@miri64 miri64 merged commit 47a6609 into RIOT-OS:master Mar 8, 2018
@aabadie aabadie deleted the boards/params/samr21-xpro branch June 8, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@kYc0o kYc0o

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @miri64 @kYc0o @smlng