boards/pba-d-01-kw2x: fix driver params usage #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
|
@smlng @PeterKietzmann @cgundogan can one of you test? I only have one that doesn't has the TCS3772 sensor on-board. |
|
will do ASAP |
miri64
added
State: waiting for other PR
|
Normally this PR should work without #8690 since the radio defines are the same in master. Not sure about the other on-board sensor devices. |
|
tested, works with all sensors |
smlng
approved these changes
Mar 8, 2018
|
tested with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates the way on-board drivers params are configured on the pba-d-01-kw2x board.
Since the driver default are the same than on this board, I just removed them. Maybe there should be a comment in the related drivers params header file ?
Issues/PRs references
Initially done in #7937 and related to #7519. Ideally, it should be merged with #8690, #7822, #8683