Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/fox: fix driver params usage #8760

Merged
merged 1 commit into from
Mar 15, 2018
Merged

boards/fox: fix driver params usage #8760

merged 1 commit into from
Mar 15, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 8, 2018

Contribution description

This PR updates the way on-board drivers params are configured on the fox board.

Issues/PRs references

Initially done in #7937 and related to #7519.

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Mar 8, 2018
miri64
miri64 approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test (since there might be something wrong with the Fox's UART - will investigate) but the changes look sane: Redundant parameters are removed and otherwise only the default configuration is overwritten in the preprocessor.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 15, 2018
@miri64
Copy link
Member

miri64 commented Mar 15, 2018 •
edited
Loading

since there might be something wrong with the Fox's UART - will investigate

Okay, since I'm not able to connect to UART even in 256ce73 (edit: initial commit of that board), I guess I am doing something wrong ^^"

@miri64 miri64 merged commit 8992729 into RIOT-OS:master Mar 15, 2018
@aabadie aabadie deleted the boards/params/fox branch June 8, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @miri64