Makefile.include: fix missing target for libraries #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cladmi
force-pushed
the
pr/fix/makefile/include/unittests
branch
from
8e3f7ba to
049d4c2
Compare
cladmi
changed the title
|
I will try a PR to show that murdock fails to detect it. |
|
This fixes #8910 for me. I'm not familiar enough with the makefiles to review the code here though. |
bergzand
added
Type: bug
cladmi
added
the
CI: ready for build
|
Even when doing @emmanuelsearch can you test ? |
|
|
|
The I added an issue to track this problem of use before define. #8913 |
|
Fixed the rule because some modules are built by packages makefile. |
|
please squash! |
Unittests add libraries in 'BASELIBS' which do not have any rules to be built as they are built by 'application.inc.mk', packages and the DIRS variable. So make complains about missing target for the unittests archives. The fix tells these files are generated when building '$(APPLICATION_MODULE).a'. The bug was introduced by RIOT-OS#8844 Fixes RIOT-OS#8910
cladmi
force-pushed
the
pr/fix/makefile/include/unittests
branch
from
ad19d71 to
94214cd
Compare
|
Rebased and squashed message |
maxvankessel
pushed a commit
to maxvankessel/RIOT
that referenced
this pull request
Apr 20, 2018
…nittests Makefile.include: fix missing target for libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittests add libraries in 'BASELIBS' which do not have any rules to be built as
they are built by 'application.inc.mk' and the DIRS variable.
So make complains about missing target for the unittests archives.
The fix tells these files are generated when building '$(APPLICATION_MODULE).a'.
The bug was introduced by #8844
Fixes #8910