Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/xtimer_usleep_short: add expected runtime #9037

Closed
wants to merge 9 commits into from
Closed

tests/xtimer_usleep_short: add expected runtime #9037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9af59b4
tests/xtimer_usleep_short: add expected runtime
Josar Apr 27, 2018
6550535
fixup! tests/xtimer_usleep_short: add expected runtime
Josar Apr 27, 2018
c4e543c
fixup! fixup! tests/xtimer_usleep_short: add expected runtime
Josar Apr 27, 2018
dfcf9e9
fixup! fixup! fixup! tests/xtimer_usleep_short: add expected runtime
Josar May 9, 2018
cb23ea4
fixup! fixup! fixup! fixup! tests/xtimer_usleep_short: add expected r…
Josar May 16, 2018
6a4b963
fixup! fixup! fixup! fixup! fixup! tests/xtimer_usleep_short: add exp…
Josar May 24, 2018
fd6a9c6
fixup! fixup! fixup! fixup! fixup! fixup! tests/xtimer_usleep_short: …
Josar May 24, 2018
ec11938
fixup! fixup! fixup! fixup! fixup! fixup! fixup! tests/xtimer_usleep_…
Josar May 29, 2018
bfe9884
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! tests/xtimer_…
Josar Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/xtimer_usleep_short/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,25 @@
#define TEST_USLEEP_MIN (0)
#define TEST_USLEEP_MAX (500)

#define TEST_TIME (125250)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine this value ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.wolframalpha.com/input/?i=500%2B499%2B498%2B+...+%2B+1

Copy link
Contributor

@aabadie aabadie Apr 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then threre's direct relationship with TEST_USLEEP_MAX and TEST_USLEEP_MIN, so I think it's useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you mean, but changed the value to be calculated.


int main(void)
{
xtimer_sleep(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This xtimer_sleep(3) break my tests when doing make flash test on some boards as the test could match the child.expect(u"This test will call xtimer_usleep for values from (\d+) down to (\d+)") line before make reset is done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions on how to fix this? Increase the sleep?

printf("This test will call xtimer_usleep for values from %d down to %d\n",
TEST_USLEEP_MAX, TEST_USLEEP_MIN);

uint32_t start, sleeping_time=0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put spaces around = operator


for (int i = TEST_USLEEP_MAX; i >= TEST_USLEEP_MIN; i--) {
printf("going to sleep %d usecs...\n", i);
start = xtimer_now_usec();
xtimer_usleep(i);
sleeping_time += xtimer_now_usec() - start;
}

printf("Slept for %" PRIu32 " expected %" PRIu32"\n", sleeping_time, TEST_TIME);

puts("[SUCCESS]");

return 0;
Expand Down
9 changes: 9 additions & 0 deletions tests/xtimer_usleep_short/tests/01-run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ def testfunc(child):
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This break should be an exit(1), not print failed then success…
It's a good time to fix it.

i = i - 1

child.expect(u"Slept for (\\d+) expected (\\d+)", timeout=3)
runtime = int(child.match.group(1))
expected = int(child.match.group(2))

if runtime < expected*0.9 or runtime > expected*1.1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tested in the test application not by the pexpect script

print("xtimer slept to long")
print("[FAILED]")
return

child.expect(u"[SUCCESS]", timeout=3)


Expand Down