sam0_common/i2c.c extra byte fix #9257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
added
Type: bug
|
Give it a quick look, some parts are dirty. I'm sure we can improve it AND support NOSTART NOSTOP. |
|
Closed in favor of #9198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides a workaround for the SAMR I2C reading an extra byte (based on hardware defined in datasheet page 513 or 514). It also is updates the return values to the error code in the API rework. It is based off of @dylad PR #9198 and is needed for the periph_i2c in PR #9168 to test it. That only file that was worked on when diff with #9198 is the cpu/sam0_common/periph/i2c.c
Issues/PRs references
Issue: #6577
Based from #9198
Needed for #9168
samr21 datasheet