-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add tests for IPv6 fragmentation #137
Comments
While looking at tests/gnrc_ipv6_ext_frag again while writing RIOT-OS/Release-Specs#137, I noticed that several of tests that I definitely wrote myself from scretch are attributed wrong (and sometimes even documented wrong). I guess this was caused by just copy-pasting the files...
+1 for extending the tests and making those tasks experimental for now in On a separate matter, tasks 4.(5-8) still remain experimental? They seem to have been passing, @aabadie ? |
Ok, then I prepare a PR with the specifications. |
Good that we test this. Pinging with 2KiB already maxes out the packet buffer xD |
When trying to ping 2 KiB, 6 KiB of packet buffer just aren't enough.
I agree +1 |
Let's discuss this in a separate issue, please. |
I just merged #137. With @leandrolanzieri and @fjmolinas agreement here, let's close this issue. |
tests: prepare for RIOT-OS/Release-Specs#137
While looking at tests/gnrc_ipv6_ext_frag again while writing RIOT-OS/Release-Specs#137, I noticed that several of tests that I definitely wrote myself from scretch are attributed wrong (and sometimes even documented wrong). I guess this was caused by just copy-pasting the files...
With IPv6 fragmentation and reassembly merged (RIOT-OS/RIOT#11623 and RIOT-OS/RIOT#11596 respectively) during the 2019.10 release cycle, I think it makes sense to extend the release specifications for packets of sizes (MTU, 2*MTU]. Specifically I would extend
03
,04
and07
with one task each to ping with packets with e.g. 2 KiB payload size.All weird corner cases should already be covered by the
tests/gnrc_ipv6_ext_frag
application (which should be covered by02
, but who knows, since it requiressudo
and people tend to skip tests that are not auto-run ;-P). However, I prefer to have at least some "in-the-wild" tests done during the release testing.TBH, I personally never tested IPv6 + 6LoWPAN fragmentation (but AFAIK @benpicco did during the testing of RIOT-OS/RIOT#11623 [edit]after rereading his review comment I'm less sure[/edit]), so we have to see if the
04
extension works as expected and I don't believe multihop (07
) was properly tested yet (tests/gnrc_ipv6_ext_frag
tests forwarding of fragments though). I would thus suggest that the04
and07
extensions should be marked as experimental at least for the first RC they are tested in, in case some weird side effects arise.The text was updated successfully, but these errors were encountered: