Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: don't use tox-gh-actions plugin #200

Merged
merged 3 commits into from
Jan 15, 2021
Merged

gh-actions: don't use tox-gh-actions plugin #200

merged 3 commits into from
Jan 15, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 12, 2021

@aabadie warned me to use that plugin, and now it shows... for some reason it does not execute neither flake8 nor pylint. This removes the usage of the tex-gh-actions plugin and also adds 3.9 tests.

@miri64 miri64 added the bug label Jan 12, 2021
@miri64 miri64 requested review from jia200x and aabadie January 12, 2021 11:04
@miri64 miri64 force-pushed the gh-action/fix/dont-use-tox-gh-action-plugin branch from 157a7a7 to 411fea8 Compare January 12, 2021 11:05
@jia200x
Copy link
Member

jia200x commented Jan 12, 2021

I'm fine with the change. @aabadie are you also ok with it?

@miri64 miri64 mentioned this pull request Jan 15, 2021
Closed
@miri64 miri64 force-pushed the gh-action/fix/dont-use-tox-gh-action-plugin branch from 7fdfe03 to ecc8109 Compare January 15, 2021 01:06
jia200x
jia200x approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. For some reason this prevents running flake8andpylint`. It would be a nice if at some point this can be done with such a plugin, but until we don't find a solution let's keep it as it's proposed here

@jia200x jia200x merged commit 9706650 into RIOT-OS:master Jan 15, 2021
@miri64 miri64 deleted the gh-action/fix/dont-use-tox-gh-action-plugin branch January 15, 2021 08:14
@miri64 miri64 mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @jia200x