tox-envfile: add support for env file #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jia200x please rebase! |
|
Needs another rebase. If done, I think this can be merged. |
miri64
approved these changes
Jul 15, 2021
fjmolinas
force-pushed
the
pr/envfile
branch
from
8833f87 to
75cf1c6
Compare
|
Rebased |
|
However, |
fjmolinas
force-pushed
the
pr/envfile
branch
from
75cf1c6 to
b5d0ffa
Compare
|
rebased... |
|
Thanks @jia200x! Really cool to have this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Some tests require an extended list of environment variables (e.g LoRaWAN tests).
This PR adds https://github.com/seanh/tox-envfile/blob/master/tox_envfile.py in order to be able to store these environment variables in an env file.
Due to limitations in the original pkg, the env file is named ".devdata.env" instead of the standard ".env". Maybe we can upstream this change at some point...
Testing
Copy the sample environment file:
And set RIOTBASE accordingly. Simply calling "tox" shouldn't complain that RIOTBASE is missing.