This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
sniffer: make serial/socket command optional #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly a preparation step to make some arguments (namely baudrate and the "serial/socket" argument) optional, to make it more usable like the old `rftest2pcap` script for the econotag.
First of all: I know this is very hacky, but sadly there is no straight-forward (and portable) way with `argparse` to make a subcommand optional, like it is the case e.g. with many `git` commands. However, this allows now also do just type ```sh ./tools/sniffer /dev/ttyACM0 112500 26 ```
miri64
force-pushed
the
sniffer/enh/serial-optional
branch
from
41fee3d to
eee0d3f
Compare
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jun 19, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jun 19, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
smlng
previously approved these changes
Jul 13, 2018
|
|
|
|
|
would prefer #40 though |
|
Ok |
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jul 13, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: I know this is very hacky, but sadly there is no
straight-forward (and portable) way with
argparseto make asubcommand optional, like it is the case e.g. with many
gitcommands.
However, this allows now also do just type
Depends on #37