Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Provide README #58

Merged
merged 7 commits into from
Feb 18, 2019
Merged

Provide README #58

merged 7 commits into from
Feb 18, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 8, 2019

Provides a README with some instructions (and the current build status of the repo).

@miri64 miri64 requested review from aabadie and smlng January 8, 2019 09:42
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, otherwise good

README.md Outdated Show resolved Hide resolved
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some structure?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Adding headlines
@miri64
Copy link
Member Author

miri64 commented Jan 8, 2019

add some structure?

Done

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Address wording comments
@miri64
Copy link
Member Author

miri64 commented Jan 8, 2019

@smlng @waehlisch are you happy with the newest wording?

@waehlisch
Copy link
Member

"software provided with RIOT beyond the simple examples [within the RIOT
codebase][riot-repo/examples]." sounds still weird.

@miri64
Copy link
Member Author

miri64 commented Jan 8, 2019

Oops, I overlooked, that that comment also contained a wording change. I only focused on the reference.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@waehlisch
Copy link
Member

Oops, I overlooked, that that comment also contained a wording change. I only focused on the reference.

that's the reason why I copied more than the reference.

@miri64
Copy link
Member Author

miri64 commented Feb 18, 2019

@smlng ping?

Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@smlng smlng merged commit 85eb9fc into RIOT-OS:master Feb 18, 2019
@miri64 miri64 deleted the readme branch February 18, 2019 16:07
@miri64
Copy link
Member Author

miri64 commented Feb 18, 2019

Wasn't squashed....

@smlng
Copy link
Member

smlng commented Feb 18, 2019

damn, I'm not used to check this ... we definitely need more checks here. I suggest to cleanup and force-push on master, to me its not a problem here.

@miri64
Copy link
Member Author

miri64 commented Feb 18, 2019

This would remove the merge commit. Let's keep it as is.

chrysn pushed a commit to chrysn-pull-requests/RIOT that referenced this pull request Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants