Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compile options to use -fnative-half-arguments-and-returns #3581

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

kahmed10
Copy link
Collaborator

No description provided.

@kahmed10 kahmed10 marked this pull request as ready for review October 31, 2024 17:51
@kahmed10 kahmed10 requested a review from causten as a code owner October 31, 2024 17:51
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (77ab44e) to head (246fe49).
Report is 128 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3581   +/-   ##
========================================
  Coverage    92.16%   92.16%           
========================================
  Files          512      512           
  Lines        21412    21412           
========================================
  Hits         19735    19735           
  Misses        1677     1677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten requested review from pfultz2 and apwojcik October 31, 2024 21:28
@kahmed10
Copy link
Collaborator Author

kahmed10 commented Nov 1, 2024

For context, this is needed as of this change to hip-clang:
llvm/llvm-project#113335

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
246fe4
Rate old
77ab44
Diff Compare
torchvision-resnet50 64 3,260.91 3,259.78 0.03%
torchvision-resnet50_fp16 64 7,003.33 6,995.97 0.11%
torchvision-densenet121 32 2,438.67 2,436.42 0.09%
torchvision-densenet121_fp16 32 4,082.22 4,071.94 0.25%
torchvision-inceptionv3 32 1,640.29 1,639.03 0.08%
torchvision-inceptionv3_fp16 32 2,763.39 2,763.00 0.01%
cadene-inceptionv4 16 776.33 776.59 -0.03%
cadene-resnext64x4 16 810.99 808.43 0.32%
slim-mobilenet 64 7,535.12 7,532.81 0.03%
slim-nasnetalarge 64 211.51 211.50 0.00%
slim-resnet50v2 64 3,504.78 3,504.45 0.01%
bert-mrpc-onnx 8 1,153.13 1,150.80 0.20%
bert-mrpc-tf 1 464.22 464.16 0.01%
pytorch-examples-wlang-gru 1 418.28 424.10 -1.37%
pytorch-examples-wlang-lstm 1 390.01 397.87 -1.98%
torchvision-resnet50_1 1 816.75 817.55 -0.10%
cadene-dpn92_1 1 405.84 436.30 -6.98% 🔴
cadene-resnext101_1 1 383.78 374.14 2.58%
onnx-taau-downsample 1 343.05 343.01 0.01%
dlrm-criteoterabyte 1 33.36 33.36 0.01%
dlrm-criteoterabyte_fp16 1 52.72 52.73 -0.03%
agentmodel 1 8,268.97 8,198.74 0.86%
unet_fp16 2 58.86 58.86 0.00%
resnet50v1_fp16 1 957.28 987.67 -3.08% 🔴
resnet50v1_int8 1 1,037.73 991.53 4.66% 🔆
bert_base_cased_fp16 64 1,170.70 1,171.75 -0.09%
bert_large_uncased_fp16 32 363.53 363.44 0.02%
bert_large_fp16 1 200.61 198.74 0.94%
distilgpt2_fp16 16 2,203.62 2,194.99 0.39%
yolov5s 1 540.13 538.41 0.32%
tinyllama 1 43.52 43.41 0.24%
vicuna-fastchat 1 173.06 174.43 -0.79%
whisper-tiny-encoder 1 418.17 418.43 -0.06%
whisper-tiny-decoder 1 425.42 426.61 -0.28%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 5388984 into develop Nov 1, 2024
23 of 24 checks passed
@causten causten deleted the gpu_comp_options branch November 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants