rocr: delete duplicated conditional expression #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize the driver discovery and move driver-specific functionality to the concrete driver implementations. Currently, this process is tightly coupled to the hsakmt which is GPU and OS specific.
Signed-off-by: Min Zhou <[email protected]>
dayatsin-amd
force-pushed
the
amd-staging
branch
from
ea66d58 to
9971e7b
Compare
|
Can you please remove the first 4 commits from PR. Otherwise looks good to me. Thank you |
dayatsin-amd
requested changes
Jan 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.