Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs following ROCm move #152

Merged
merged 1 commit into from
Mar 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/therock_subproject.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ endif()
# don't need to probe warning flag availability and just have a hard-coded
# list. We only squelch warnings here that do not signal code correctness
# issues.
# TODO: Clean up warning flags (https://github.com/nod-ai/TheRock/issues/47)
# TODO: Clean up warning flags (https://github.com/ROCm/TheRock/issues/47)
set(THEROCK_AMD_LLVM_DEFAULT_CXX_FLAGS
-Wno-documentation-unknown-command
-Wno-documentation-pedantic
Expand Down
2 changes: 1 addition & 1 deletion comm-libs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if(THEROCK_ENABLE_RCCL)
# to work and it will only do so if the system resolver reports it not found
# without any other error (which due to the signature, our resolver will
# hard fail). Once fixed, `rocm-core` should be added to the BUILD_DEPS
# and this removed: https://github.com/nod-ai/TheRock/issues/18
# and this removed: https://github.com/ROCm/TheRock/issues/18
ROCM
RUNTIME_DEPS
hip-clr
Expand Down
2 changes: 1 addition & 1 deletion compiler/pre_hook_amd-comgr.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ else()
endif()

# The comgr tests have a circular dependency on the HIP runtime.
# https://github.com/nod-ai/TheRock/issues/67
# https://github.com/ROCm/TheRock/issues/67
set(BUILD_TESTING OFF CACHE BOOL "DISABLE BUILDING TESTS IN SUBPROJECTS" FORCE)

set(CMAKE_INSTALL_RPATH "$ORIGIN;$ORIGIN/llvm/lib;$ORIGIN/rocm_sysdeps/lib")
2 changes: 1 addition & 1 deletion core/post_hook_hip-clr.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# See: https://github.com/nod-ai/TheRock/issues/21
# See: https://github.com/ROCm/TheRock/issues/21
if(HIPCC_BIN_DIR)
message(FATAL_ERROR "The legacy HIPCC_BIN_DIR was somehow set, indicating a bug in the clr CMake files: ${HIPCC_BIN_DIR}")
endif()
Expand Down
2 changes: 1 addition & 1 deletion docs/development/build_containers.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

The project aims to build on a wide variety of Linux operating systems and compilers, but when it comes to producing portable builds, we use EL containers based on the [manylinux](https://github.com/pypa/manylinux) project. This gives us the ability to produce binaries with wide compatibility by default to facilitate tarball distribution and embedding into other packages.

The CI uses a custom built [therock_build_manylinux_x86_64](https://github.com/nod-ai/TheRock/pkgs/container/therock_build_manylinux_x86_64). See the `/dockerfiles/build_manylinux_x86_64.dockerfile`. It is automatically rebuilt on pushes to `main`. For testing, changes can be pushed to a `test-docker-*` branch, which will result in a corresponding tag in the package registry. See the dockerfile for instructions to build locally.
The CI uses a custom built [therock_build_manylinux_x86_64](https://github.com/ROCm/TheRock/pkgs/container/therock_build_manylinux_x86_64). See the `/dockerfiles/build_manylinux_x86_64.dockerfile`. It is automatically rebuilt on pushes to `main`. For testing, changes can be pushed to a `test-docker-*` branch, which will result in a corresponding tag in the package registry. See the dockerfile for instructions to build locally.
2 changes: 1 addition & 1 deletion docs/development/windows_support.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ You will need:
### Clone and fetch sources

```bash
git clone https://github.com/nod-ai/TheRock.git
git clone https://github.com/ROCm/TheRock.git
python ./build_tools/fetch_sources.py
```

Expand Down
2 changes: 1 addition & 1 deletion examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ add_test(

# TODO: HIP language support not based on an /opt/rocm installed SDK
# must have these three cache variables set to avoid language setup
# error. https://github.com/nod-ai/TheRock/issues/102
# error. https://github.com/ROCm/TheRock/issues/102
-DCMAKE_HIP_PLATFORM=amd
"-DCMAKE_HIP_COMPILER=${THEROCK_BINARY_DIR}/dist/rocm/lib/llvm/bin/clang++"
"-DCMAKE_HIP_COMPILER_ROCM_ROOT=${THEROCK_BINARY_DIR}/dist/rocm"
Expand Down
2 changes: 1 addition & 1 deletion examples/cpp-sdk-user/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ option(THEROCK_ENABLE_SOLVER "Whether rocsolver/hipsolver are available" ON)
option(THEROCK_ENABLE_SPARSE "Whether rocsparse/hipsparse are available" ON)

if(THEROCK_ENABLE_HIP)
# TODO: Don't require HIP_PLATFORM https://github.com/nod-ai/TheRock/issues/68
# TODO: Don't require HIP_PLATFORM https://github.com/ROCm/TheRock/issues/68
set(HIP_PLATFORM "amd")
find_package(hip CONFIG REQUIRED)
message(STATUS "**** HIP Configuration:")
Expand Down
2 changes: 1 addition & 1 deletion math-libs/BLAS/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ IGNORE_PACKAGES
# to work and it will only do so if the system resolver reports it not found
# without any other error (which due to the signature, our resolver will
# hard fail). Once fixed, `rocm-core` should be added to the BUILD_DEPS
# and this removed: https://github.com/nod-ai/TheRock/issues/18
# and this removed: https://github.com/ROCm/TheRock/issues/18
ROCM
RUNTIME_DEPS
hip-clr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This is actually worse than that because it leaks global variables that establis

Also fixes a bug in hip-config.cmake where it enforces that hipcc exists even if not taking the install branch in the code above.

See: https://github.com/nod-ai/TheRock/issues/21
See: https://github.com/ROCm/TheRock/issues/21
---
CMakeLists.txt | 43 ++++++++++++++++++++++++--------------
hipamd/CMakeLists.txt | 5 ++++-
Expand Down
2 changes: 1 addition & 1 deletion third-party/host-blas/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ therock_cmake_subproject_declare(therock-host-blas
CMAKE_ARGS
-DBUILD_SHARED_LIBS=ON
# TODO: DYNAMIC_ARCH=ON produces illegal elf files
# See: https://github.com/nod-ai/TheRock/issues/83
# See: https://github.com/ROCm/TheRock/issues/83
-DDYNAMIC_ARCH=OFF
-DC_LAPACK=ON
-DBUILD_TESTING=OFF
Expand Down
Loading