Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

therock_amdgpu_targets.cmake: RX 7700S is a dgpu #172

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

scottt
Copy link
Contributor

@scottt scottt commented Mar 8, 2025

AMD RX 7700S is in a dgpu and not an igpu.

See how its a separate graphics module for the Framework Laptop 16 https://frame.work/products/16-graphics-module-amd-radeon-rx-7700s

@scottt scottt changed the title therock_amdgpu_targets.cmake: RX 7700S is dgpu therock_amdgpu_targets.cmake: RX 7700S is a dgpu Mar 8, 2025
AMD RX 7700S is in a dgpu and not an igpu.
See how its a separate graphics module for the Framework Laptop 16
https://frame.work/products/16-graphics-module-amd-radeon-rx-7700s
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still working on the best way to bundle these together and may change the category names in the future. But thank you for spotting/fixing the current error.

@stellaraccident stellaraccident merged commit 4a29ae0 into ROCm:main Mar 8, 2025
2 of 3 checks passed
@scottt
Copy link
Contributor Author

scottt commented Mar 8, 2025

@stellaraccident , If you're trying to group GPU support into categories, I do have suggestions as someone not familiar with AMD product lines:

  • make the images produced by TheRock have a clear mapping with the tables on the System requiresments (Linux) and System requirements (Windows) pages e.g. one tab in the table could map to one image

  • grouping of "data center MI300 GPUs (gfx94x)", "RDNA 3 gfx110x", and "RDNA4 gfx120X" is relatively easy to understand due to differing architecture, the gfx110x-dgpu vs gfx110x-igpu distinction less so

  • if the RDNA3.5 GPUs were shown in one "AMD APU" tab on the system requiremens page, having a image for them would also be intuitive etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants