Put saveguard to avoid defining target more than once

[mtaillefumier]

• set the INTERFACE_INCLUDE_DIRECTORIES property
• These safeguards are needed when the CMakeLists.txt contains:

enable_language(HIP)
find_package(hipblas)

In that case add_library is called twice.

[iassiour]

Hi @mtaillefumier would it be possible to provide a few more details i.e attach a full reproducer and some logs of the error you are getting, if any. Are you trying to build for nvidia platform?

[mtaillefumier]

I am using hipblas, hipfft, and hip on nvidia platforms. the minimal reproducer is this block of code

cmake_minimum_required(VERSION 3.28)

project(hip-cuda-test)

set(CMAKE_HIP_ARCHITECTURES 90)
set(CMAKE_HIP_PLATFORM "nvidia")
enable_language(HIP)
find_package(CUDAToolkit)
find_package(hipblas REQUIRED IMPORTED CONFIG)
find_package(hipfft REQUIRED IMPORTED CONFIG)

cuda should be available before running cmake. If cmake is called with this CMakeLists.txt , we get

CMake Error at /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config-nvidia.cmake:23 (add_library):
  add_library cannot create imported target "hip::device" because another
  target with the same name already exists.
Call Stack (most recent call first):
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config.cmake:153 (include)
  /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hipfft-6.3.0-6qywxfcm6hxqxoo6fbk6v6op5eik7du2/lib/cmake/hipfft/hipfft-config.cmake:90 (find_dependency)
  CMakeLists.txt:10 (find_package)

CMake Error at /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config-nvidia.cmake:23 (add_library):
  add_library cannot create imported target "hip::host" because another
  target with the same name already exists.
Call Stack (most recent call first):
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config.cmake:153 (include)
  /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hipfft-6.3.0-6qywxfcm6hxqxoo6fbk6v6op5eik7du2/lib/cmake/hipfft/hipfft-config.cmake:90 (find_dependency)
  CMakeLists.txt:10 (find_package)
CMake Error at /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config-nvidia.cmake:23 (add_library):
  add_library cannot create imported target "hip::amdhip64" because another
  target with the same name already exists.
Call Stack (most recent call first):
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hip-6.3.0-n7hw6bc7wzyvb4e6gn4wn4mcfgpreywx/lib/cmake/hip/hip-config.cmake:153 (include)
  /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /opt/spack/linux-fedora41-cascadelake/gcc-13.3.0/hipfft-6.3.0-6qywxfcm6hxqxoo6fbk6v6op5eik7du2/lib/cmake/hipfft/hipfft-config.cmake:90 (find_dependency)
  CMakeLists.txt:10 (find_package)

Moreover even if it passes adding the defined targets will not add the include directories paths which is also an issue.
Guarding around a add_library is required because the same config file can be called multiple times over by different packages. This problem only happen with hip/nvidia