Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contribution guidelines to the documentation #843

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Add contribution guidelines to the documentation #843

merged 3 commits into from
Sep 5, 2023

Conversation

bwroblew
Copy link
Contributor

No description provided.

aosewski
aosewski reviewed Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@aosewski aosewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Added few minor comments.

You could also point out the need of adhering to the specific code-formatting rules we use.

docs/Contributors_Guide.rst Outdated Show resolved Hide resolved
docs/Contributors_Guide.rst Outdated Show resolved Hide resolved
docs/Contributors_Guide.rst Show resolved Hide resolved
@bwroblew
Copy link
Contributor Author

You could also point out the need of adhering to the specific code-formatting rules we use.

Sure, forgot about that. Added a new bullet point about using clang-format and pre-commit.

@bwroblew bwroblew requested a review from zjing14 August 22, 2023 13:25
@bwroblew bwroblew merged commit 1e1f82d into develop Sep 5, 2023
@illsilin illsilin deleted the bwroblew/contrib branch December 7, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aosewski aosewski aosewski left review comments

@illsilin illsilin illsilin approved these changes

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@zjing14 zjing14 Awaiting requested review from zjing14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwroblew @aosewski @illsilin