Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use B64 instead of B32 #1548

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Use B64 instead of B32 #1548

merged 1 commit into from
Jan 16, 2025

Conversation

KKyang
Copy link
Contributor

@KKyang KKyang commented Jan 15, 2025

No description provided.

@KKyang KKyang force-pushed the b64 branch 3 times, most recently from b86ac8c to 251a405 Compare January 15, 2025 06:00
@KKyang
Copy link
Contributor Author

KKyang commented Jan 15, 2025

============================================ 84 passed, 37 skipped in 3440.03s (0:57:20) ============================================
py3: exit 0 (3440.22 seconds) /data0/yangwen/hipBLASLt/tensilelite> py.test -v --basetemp=/tmp/CI_out/py3/tmp --junit-xml=/data0/yangwen/hipBLASLt/tensilelite/python_tests.xml --junit-prefix=py3 --color=yes -n 4 --prebuilt-client=/tmp/CI_out/py3/client/0_Build/client/tensile_client Tensile/Tests -m common pid=230985
py3: OK (3580.48=setup[10.83]+cmd[0.41,129.02,3440.22] seconds)
congratulations :) (3580.56 seconds)

ssuyuanchang
ssuyuanchang previously approved these changes Jan 15, 2025
View reviewed changes
@ssuyuanchang
Copy link
Contributor

Please check SGPRs of B64 instructions are aligned.

hcman2
hcman2 previously approved these changes Jan 15, 2025
View reviewed changes
@hcman2
Copy link
Contributor

hcman2 commented Jan 15, 2025

Please check SGPRs of B64 instructions are aligned.

@KKyang KKyang dismissed stale reviews from hcman2 and ssuyuanchang via 571844c January 15, 2025 08:20
hcman2
hcman2 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@hcman2 hcman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@KKyang KKyang requested a review from ssuyuanchang January 15, 2025 09:22
@KKyang
Copy link
Contributor Author

KKyang commented Jan 15, 2025

[----------] Global test environment tear-down
[==========] 53103 tests from 13 test suites ran. (1305738 ms total)
[ PASSED ] 53103 tests.
hipBLASLt version: 1300

@KKyang KKyang merged commit 0ac3cb1 into develop Jan 16, 2025
10 of 12 checks passed
@KKyang KKyang deleted the b64 branch January 16, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcman2 hcman2 hcman2 approved these changes

@ssuyuanchang ssuyuanchang ssuyuanchang approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKyang @ssuyuanchang @hcman2