Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denseconversions #97

Merged
merged 16 commits into from
Apr 5, 2020
Merged

Denseconversions #97

merged 16 commits into from
Apr 5, 2020

Conversation

YvanMokwinski
Copy link
Contributor

Integrate hipsparseXdense2csr, hipsparseXdense2csc, hipsparseXcsc2dense and hipsparseXcsr2dense
for X=S,D,C,Z.

ntrost57
ntrost57 reviewed Apr 2, 2020
View reviewed changes
library/src/nvcc_detail/hipsparse.cpp
(const cuDoubleComplex*)A,
ld,
nnzPerRow,
(const cuDoubleComplex*)csrVal,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be const

Copy link
Contributor

@ntrost57 ntrost57 Apr 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csrVal cannot be const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed.

ntrost57
ntrost57 reviewed Apr 2, 2020
View reviewed changes
library/src/nvcc_detail/hipsparse.cpp
(const cuComplex*)cscVal,
cscRowInd,
cscColPtr,
(const cuComplex*)A,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be const

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cannot be const

@YvanMokwinski YvanMokwinski merged commit 7758e11 into ROCm:develop Apr 5, 2020
@YvanMokwinski YvanMokwinski mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsandham jsandham jsandham left review comments

@ntrost57 ntrost57 ntrost57 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YvanMokwinski @ntrost57 @jsandham