Ck update contraction #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afanfa
requested review from
saadrahim,
LisaDelaney,
cgmillette,
bragadeesh,
mkarunan,
dlangbe and
CongMa13
as code owners
CongMa13
requested changes
Oct 17, 2023
There was a problem hiding this comment.
The last commit is the only change in this PR. Please rebase the PR branch onto develop branch first.
Suppose upstream is https://github.com/ROCmSoftwarePlatform/hipTensor.git
checkout your PR branch
git fetch upstream
git rebase -i --onto upstream/develop HEAD^ HEAD
solve the conflict
git rebase --continue
774a119 to
21a9d70
Compare
|
Can the reviewers please review and merge this PR today? The necessary changes have been merged into CK develop branch yesterday. Our CI will remain broken until we have the matching changed in hipTensor. |
cgmillette
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actor-critic algorithm selection for new CK kernels