Skip to content

Commit

Permalink
[hipcc] Remove extra definition of hipBinUtilPtr_ in derived platforms
Browse files Browse the repository at this point in the history
Fixes UB when hipBinUtilPtr_ is used.
  • Loading branch information
LunNova committed Oct 11, 2024
1 parent 5a9ddc6 commit f259eca
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion amd/hipcc/src/hipBin_amd.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ THE SOFTWARE.

class HipBinAmd : public HipBinBase {
private:
HipBinUtil* hipBinUtilPtr_;
string hipClangPath_ = "";
string roccmPathEnv_, hipRocclrPathEnv_, hsaPathEnv_;
PlatformInfo platformInfoAMD_;
Expand Down
1 change: 0 additions & 1 deletion amd/hipcc/src/hipBin_nvidia.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ THE SOFTWARE.

class HipBinNvidia : public HipBinBase {
private:
HipBinUtil* hipBinUtilPtr_;
string cudaPath_ = "";
PlatformInfo platformInfoNV_;
string hipCFlags_, hipCXXFlags_, hipLdFlags_;
Expand Down

0 comments on commit f259eca

Please sign in to comment.