Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hipcc] Remove extra definition of hipBinUtilPtr_ in derived platforms #183

Closed
wants to merge 1 commit into from

Conversation

LunNova
Copy link

@LunNova LunNova commented Oct 11, 2024

Fixes UB when hipBinUtilPtr_ is used.

Fixes #182

@LunNova LunNova changed the base branch from amd-staging to amd-trunk-dev October 11, 2024 16:23
@LunNova LunNova changed the base branch from amd-trunk-dev to amd-staging October 11, 2024 16:26
@lamb-j lamb-j added the hipcc Related to HIPCC label Oct 11, 2024
Copy link

@david-salinas david-salinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcgu-amd
Copy link

tcgu-amd commented Jan 7, 2025

@LunNova, thanks for your contribution! You PR has been approved cloned to our internal repo. I will close this PR for now unless further problems arise. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hipcc Related to HIPCC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: hipBinUtilPtr_ never initialized in amd/hipcc/src/hipBin_amd.h
4 participants