Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Add TODO and namespace for duplicate utils #99

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ergawy
Copy link

@ergawy ergawy commented Jun 5, 2024

Adds a TODO for the duplicated utils that we had to copy for do concurrent mapping. Also introduces the duplicate utils in a separate internal namespace to avoid naming conflicts.

Adds a TODO for the duplicated utils that we had to copy for do
concurrent mapping. Also introduces the duplicate utils in a separate
`internal` namespace to avoid naming conflicts.
@ergawy ergawy requested a review from skatrak June 5, 2024 04:50
Copy link
Member

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ergawy ergawy merged commit ecdd431 into ROCm:amd-trunk-dev Jun 5, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants