Remove Critical Trace Support #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jrmadsen
commented
Jan 11, 2024
jrmadsen
commented
- Critical trace support has been superseded by causal profiling support
- Critical trace support was removed in Omnitrace v1.11.0 due to incomplete implementation
jrmadsen
added
the
omnitrace-critical-trace
jrmadsen
commented
Jan 11, 2024
jrmadsen
force-pushed
the
remove-critical-trace
branch
from
8f7003f to
934f71d
Compare
jrmadsen
force-pushed
the
remove-critical-trace
branch
from
0b576e4 to
ee27252
Compare
jrmadsen
force-pushed
the
remove-critical-trace
branch
from
ee27252 to
679455b
Compare
- fix spelling
- statically allocate shared pointers for timemory manager and hash id/aliases to prevent use-after-free errors
jrmadsen
force-pushed
the
remove-critical-trace
branch
from
679455b to
1757d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.