Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to install cmake-3.18.4 #413

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD commented Oct 30, 2024

Update internal CMake files to match with cmake_minimum_requred(VERSION 3.18.4)
This was the latest version used all the project's cmake_minimum_required definitions.

@dgaliffiAMD dgaliffiAMD requested a review from jrmadsen as a code owner October 30, 2024 15:48
This is the latest version used in cmake_minimum_required.

Signed-off-by: David Galiffi <[email protected]>
@dgaliffiAMD dgaliffiAMD force-pushed the update-workflow-cmake branch from 079d778 to 4cacea4 Compare October 30, 2024 16:32
@dgaliffiAMD dgaliffiAMD changed the title Update workflow to install cmake-3.21.4 Update workflow to install cmake-3.21 Oct 30, 2024
@dgaliffiAMD dgaliffiAMD changed the title Update workflow to install cmake-3.21 Update workflow to install cmake-3.18.4 Oct 30, 2024
@dgaliffiAMD
Copy link
Collaborator Author

Building the Dyninst component fails after setting cmake_minimum_requred to 3.21. Taking it back to 3.18.4. I just want to get everything synchronized in this PR, we can investigate that failure afterwards.

@dgaliffiAMD dgaliffiAMD merged commit 5814891 into amd-staging Oct 30, 2024
44 checks passed
@dgaliffiAMD dgaliffiAMD deleted the update-workflow-cmake branch October 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant