Fix for heap buffer overflow in partition_kernel_impl() #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB4444
requested review from
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
stanleytsang-amd
approved these changes
Mar 25, 2024
|
All tests pass. LGTM |
stanleytsang-amd
pushed a commit
to stanleytsang-amd/rocPRIM
that referenced
this pull request
Apr 3, 2024
…ck (ROCm#538) Co-authored-by: Nick Breed <[email protected]>
stanleytsang-amd
added a commit
that referenced
this pull request
Apr 18, 2024
…ck (#538) (#546) Co-authored-by: Nick Breed <[email protected]> Co-authored-by: Nick Breed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check to partition kernel to prevent read and write out-of-bounds. The number of indices is partitions+1, this are also the number of threads necessary. The writes and reads out-of-bounds have the same value as the last value in the
indicesarray.