forked from triton-lang/triton
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multihead latent attention kernel #699
Draft
juuso-oskari
wants to merge
16
commits into
main_perf
Choose a base branch
from
jukorhon/MLA
base: main_perf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or cauusing out of memory
…bly dtype or masking issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLA.py
Kernel that implements Multihead Latent Attention from DeepSeekV3. I'm following the reference pytorch implementation here.
For the first version the idea is to just fuse the absorbed gemms into flash attention.
In pseudocode:
Launch of the kernel:
And then how the kernel gets called:
TODO:
Problem is that even the reference "naive" and "absorb" implementations do not produce the same result. This makes it hard to know if the MLA kernel implementation is correct or not.
Check that the math is right. Can we even fuse the "absorbed" implementation with FA, because it has that additional
x = torch.einsum("bshc,hdc->bshd", x, wkv_b[:, -self.v_head_dim:])
? I suppose it shouldnt matter...