GL/Vulkan: Grand Theft Auto V graphical issues

[MarioSonic2987]

Graphical issues:

• Distorted UI elements (HUD, loading screens...) - Fixed in rsx: Pass vertex attributes streamed via register writes in BE layout #10453

• Black textures - Fixed in rsx: Implement separable MRT masks #6415

• Dark shadows - Fixed in rsx/fp: Fix PK2/UP2 instruction #8186

• Broken ambient occlusion - Fixed in rsx: Simplify support for ABGR formats #8713

• Trevor's outfit changes color (red or black) and other characters during prologue's mission - Fixed.

• Broken foliage in some locations - Fixed in rsx: Support CSAA transparency without multiple rasterization samples #6228

• No color in skybox - Fixed in rsx/fp: Fix precision clamping on MAD instruction #8243

• Broken reflections (Only present in Vulkan.)

• Weird tracing when rotating the camera - Fixed in rsx: Implement separable MRT masks #6415

Footage (June 25, 2019)

Log OpenGL
Shaderlog OpenGL
RenderDoc OpenGL (Loading screen and ingame)

Original comment

With https://github.com/RPCS3/rpcs3/commit/a08e79f4267b5e9fab82949a5f011eb40aca76b0, GTA V renders its UI like this (look at the Rockstar's logo):

But with RenderDoc, I was able to modify the shaders. I went to the vertex one to investigate what was causing that bug. And I found these two lines of code:

By changing bits 216 and 217, it fixed Rockstar's logo's orientation somehow, but the rest of UI is moved and rotated.

In conclussion, this bug is caused, likely, by a vertex shader instruction badly implemented.

Log OpenGL
Shaderlog OpenGL - It's important the latest generated vertex shader.
RenderDoc OpenGL

[kd-11]

Actually that change just changes referenced data that is uploaded from the cpu. There is no ARL preceding it meaning the values are intentionally that way (also confirmed in that swapping them rotated everything). Might be a vertex register misalignment or something broken in cell side calculations.

[MarioSonic2987]

With 345f92a:

This screenshot is taken with PPU interpreter fast and SPU interpreter precise, and there's no graphic difference.

RSX Capture Loading screen (Vulkan)

[MarioSonic2987]

Ace Combat Infinity, like GTA V, has the same distorted UI bug. With these settings and with/without Force CPU blit, it doesn't improve.

Screenshot of the bug:

RSX Capture (ACI and GTA V)

[MarioSonic2987]

I've attached the latest capture of the distorted UI glitch.

RSX Capture (Pause menu)

[MarioSonic2987]

This game needs Write Color Buffers to fix lighting outside.

Screenshot comparison

Without WCB:

With WCB:

[MarioSonic2987]

I've attached a RDC in Los Santos to show the graphical issues.

RenderDoc VK

[MarioSonic2987]

I've attached a OpenGL renderdoc trace for the dark shadows. Tested with 0.0.7-8700-32a4c224.

RenderDoc OpenGL

[MarioSonic2987]

Raindrops are rendered by using WCB+WDB+RCB+RDB.

Missing raindrops

Models no longer turn black in certain camera angles. But the red textures are still there:

[The-SamminAter]

I'm getting severely distorted/laggy audio, and for some reason characters are red.

I'm also getting distorted graphics

[MarioSonic2987]

Reflections are broken, like in these puddles.

[MarioSonic2987]

Sea isn't vertex-exploded if you disable WCB, as well the weird garbage glitch:

With WCB enabled:

[xddxd]

Ambient occlusion seems to be broken as well.

Prologue shots

RPCS3

RealHW shot from Youtube

PC

Franklin's house

RPCS3

PC

 PC and RPCS3 renderdocs https://www.dropbox.com/s/7jj8lff29mc5yne/gtavrdc.7z?dl=0

[kd-11]

For post-processing missing bugs, please make sure to test with all the buffer options enabled in case the game is using SPUs for some effects.

[kd-11]

And also accurate xfloat just in case. There's a very large chance this effect is not done GPU-side given how weak the shader pipes are on RSX.

[xddxd]

In the image WCB+WDB+RCB+RDB and accurate xfloat are enabled, no change.

In addition to the settings mentioned above, I tried SRM and CPU blit as well, no change.

[MarioSonic2987]

Broken ambient occlusion is now fixed.

[MarioSonic2987]

I attached two RSX Captures for the broken UI bug.

RSX Captures (Pause menu and brightness calibration screen)

[Xcedf]

Dudes don't turn red anymore during intro mission
https://youtu.be/LE8C-12tIKw
unfortunately game froze during capture, but still

[MarioSonic2987]

@Xcedf I can confirm that the red texture bug is fixed, even if you get injured.

But it still happens with OpenGL.

Cellphone screen has now correct colors. Previously, colors were inverted.

Although car reflections are missing in OpenGL. Vulkan shows them correctly.

[Xcedf]

@MarioSonic2987 can't get to Franklin mission in the car shop cause of freezing, maybe Setarian strange monkey face bug is also fixed. Besides do you know maybe game need some special settings to maintain stability?

[MarioSonic2987]

@Xcedf You need to change Driver Wake-Up Delay to, at least, 400 μs.

The "monkey face" bug is still there, but it happens when a character is too close to the camera. It also happens in the prologue in the same manner (see Michael's jacket in my previous comment).

[Xcedf]

@MarioSonic2987 Freezes for me even on 5000μs.

[Xcedf]

Water in the ocean seems to be no longer vertex exploding
recent master build, wawes are fine
https://youtu.be/yW397eIr-_U
for example some older build, feels like it's boiling
https://youtu.be/xN0pUXDlx9o
Reflections are still mess, but water in the pool no longer radioactive on Vulkan as well

[MarioSonic2987]

I can confirm water doesn't freak out in certain camera angles:

But reflections are still borked.

However, when you dive into the water, it looks fine.

[MarioSonic2987]

Broken reflections in vehicles and puddles in OpenGL is a regression caused by PR #8710.

[jokoputera]

How about in the KD11 latest release?
#10764

[MarioSonic2987]

Nothing changed with #10764.

Remaining issues:

• OpenGL
  • Missing car reflections (Regression introduced in rsx: Unify composite texture creation and management #8710) - Fixed.
  • Sea is vertex-exploded (Regression) - Fixed.
• Vulkan
  • Rainbow blocky artifacts (Old regression caused by rsx: Rewrite DMA transfer handling [part 3 of 3] #6359) - Improved by PR rsx: Improve surface<->texture cache communication #13077.
  • Broken reflections (Bug)
• Both backends
  • Broken textures in some character models during cutscenes (Bug) - Fixed.
• Non-graphical issues
  • (Random?) Loud noises during gameplay - Fixed.

[aakh1361]

In Gta V Most of the time, loud noises are made when entering the tunnel

[Xcedf]

@MarioSonic2987 you're saying that rainbow artifacts is an old regression, so it worked on Vullkan at some point?

[MarioSonic2987]

Rainbow blocky artifacts regression present in Vulkan are caused by PR #6359. Commit 91d7110. Discovered by Xcedf.

[MarioSonic2987]

Characters no longer turn black in cutscenes:

[MarioSonic2987]

Not a graphical fix, but loud noises in most situations, like this cutscene, are no longer present.

[Darkhost1999]

Not a graphical fix, but loud noises in most situations are no longer present.

Indeed loud noises are still present at randomly occurring times but nowhere near the amount of frequency as before. Very rare for pops and bangs now.

[Xcedf]

@Darkhost1999 remove PPU Cache and try again, it was LLVM fix

[Darkhost1999]

@Darkhost1999 remove PPU Cache and try again, it was LLVM fix

I have removed all of my caches and compiled them all again.
The loud pops and bangs are rare not gone.

[Xcedf]

@Darkhost1999 can you run this palce in prologue
this is how it sounded before(door sound)
https://youtu.be/ESm0c1cHzlI?t=8
and this is after the fix
https://youtu.be/jW1jHhpoTrY?t=6

[Darkhost1999]

That would defeat the entire purpose of the error still exists but occurs less often. Because now you're asking me to pick and choose an area of the game that works now to record and prove my point that will not come to past because it'll only prove your point.

[Darkhost1999]

In the end wrong issue ticket anyways.

[Xcedf]

Did you remember me asking to change or drop your point? I can't. I'm just asking to test this certain place in the game that's it, to make sure that at least this is working.

[Darkhost1999]

Alright but that section of the game does work and is fixed. So if that's what you want to know. It is indeed working there Simone's was worse I'll record later then.

[Darkhost1999]

In the event it has not been said water is a regression.

Build with regression #6359

Zerox used illusions build as a base. Then just reverted things from there.
https://discord.com/channels/272035812277878785/272035812277878785/934899723461066772
Although I still see no source code or anything to show what changes were made if you find this useful. Maybe the fix can be added to master soon

[Lucas7yoshi]

A regression occured, the game completely locks up at the "Get to the car" stage of prologue, FPS not changing

This has occured every time for 5 times.

0.0.24-14133
GTA 5 is updated with all updates to 1.27

Using all compatibility options described here https://wiki.rpcs3.net/index.php?title=Grand_Theft_Auto_V

Footage/log is from fresh cache
Video: https://www.youtube.com/watch?v=J6wHd1I3ccI
Log file: https://sx.l7y.ca/gta5_2022_09_08_lucas7yoshi_RPCS3_fH8nLmQz8.log.gz

[Darkhost1999]

the game completely locks up at the "Get to the car" stage of prologue

Debugger wouldn't stop mentioning getllar so I enabled accurate RSX reservation access and it worked. I tested as far back as #12234 and gave up.
Just enable accurate RSX reservation access then as soon as you're Franklin you don't "need" the setting anymore. But it also prevents freezing when swimming as anyone later in game.

[MarioSonic2987]

Tested on 0.0.24-14195.

OpenGL issues

It has broken ambient occlusion, missing car reflections and minor vertex explosions in the water:

Character's portrait in the pause menu is rendered black (correct in Vulkan):

Red models in certain conditions (when someone gets injured, for example) are no longer present:

Vulkan-exclusive glitches (rainbow garbage and broken reflections) are still present.

[MarioSonic2987]

PR #12762 breaks graphics in Vulkan. OpenGL works fine.
image

Edit: Fixed.

[MSuih]

Vulkan regression might be fixed by #12768

[MarioSonic2987]

That PR fixes this regression.

[kd-11]

Check if water is fixed by #13070

[MarioSonic2987]

Flickering rainbow glitches are now almost fixed in PR #13077:

It's still there, but it's MUCH better than before.

But the water still looks wrong.

[Ordinary205]

Intermittent vertex explosions on vehicles still occurs even on the latest master.

Desktop.2023.08.19.-.19.54.06.02_Trim.mp4

RPCS3.log.gz

[Lethality5001]

Will water be fixed soon? Or car flickering when damaged enough