Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Maintenance fixes [3] #12762

Merged
merged 3 commits into from
Oct 7, 2022
Merged

rsx: Maintenance fixes [3] #12762

merged 3 commits into from
Oct 7, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 6, 2022

  • Fix program invalidation. Avoids referencing the wrong backend shader when the current pipeline is changed for a similar one.
  • vk: Avoid unnecessary dynamic state updates every draw call. Improves performance and makes debug traces easier to follow.
  • gl: Fix texture slice gather/reconstruction for cubemap and 3D. Fixes broken reflections in most games when using OpenGL.

Fixes #12580

kd-11 added 3 commits October 6, 2022 19:31
- Use correct target types
- Fix key generation to apply differently for each target type
@MarioSonic2987
Copy link
Contributor

Fixes missing reflections in Grand Theft Auto V using OpenGL.

Before:
image
image

After:
image
image

It also fixes broken character portrait in the pause menu:
image
image

@Darkhost1999
Copy link
Contributor

This looks like fun

Master.mp4

Master.log

PR.mp4

PR_log.zip

Allow host GPU label fixes flickering bushes
WCB Fixes everything
Accurate rsx reservation access + atomic fifo improves stability.
RCB, WDB, RDB not required but often improves image quality. Should work anyways in the "ideal world"

@kd-11 kd-11 merged commit df46e51 into RPCS3:master Oct 7, 2022
@Darkhost1999
Copy link
Contributor

I feel like I wasted my time testing anything

@kd-11
Copy link
Contributor Author

kd-11 commented Oct 7, 2022

I feel like I wasted my time testing anything

You could have been a little bit clear with your message. "This looks like fun" and two videos which are both broken and you also say "WCB fixes everything" doesn't sound like you were reporting a problem.

@Darkhost1999
Copy link
Contributor

You're right. Refresh the pagw and videos work fine for me.
And I wasn't thinking about the communication towards another person. Especially if they weren't able to watch the videos. Still videos work perfectly for me. When I opened the website from desktop I was like what? They're mp4s what github always uses. And with 1 single refresh. Perfect.

@Darkhost1999
Copy link
Contributor

Regardless this is now merged and I'm making sure I'm more detailed in the regression report. Uploading rsx captures to link because github can't just accept the files as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants