rsx: Remove incorrect hack #13158
Merged
rsx: Remove incorrect hack #13158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The emulator won't update from a previous build to this new build. Tried updating from 0.0.25-14516, but it only updates to 0.0.25-14517 |
|
@Rex000 Are you on macOS? |
Can confirm this for Windows 10, no automatic update! I downloaded the update with this fix manually and got the "experimental build" warning. |
|
Its not related to kd-11's change. It's due to Cirrus dropping x86 macos containers after new years. We have been aware since before it happened, and it was being looked into for awhile now. |
Windows 10 |
|
Locking due to spam |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit was originally added to restore previously working functionality that was still not understood at the time. It solved the regression but I never went back to figure out if the "fix" was correct after making all the texture encoding discoveries using realhw. Turns out this hack actually breaks tons of games and the original bug was fixed properly years ago.
See notes in the guilty commit: f559c08
Fixes #8718 and probably a multitude of other alpha-related glitches.