Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RT_DEBUG_SCHEDULER_AVAILABLE check. #4740

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

Guozhanxin
Copy link
Member

@Guozhanxin Guozhanxin commented May 28, 2021

拉取/合并请求描述:(PR description)

[
在获取锁的时候,如果调度器不可用,会导致系统异常,而且没有任何提示信息,破坏临界区。用来检查是否存在滥用 rt_enter_critical 的情况。
所以添加了两种情况下的检查:

  • 获取锁且不等待时,不论能否获取到都不做任何处理
  • 不论能否获取到锁,只要等待,都要检查调度器是否可用(可以被调度走:检查调度器不被锁,且处于线程模式下)。

在ART-Pi上完成了测试。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin Guozhanxin requested a review from armink May 28, 2021 06:52
@armink armink requested a review from jesven May 28, 2021 08:48
components/drivers/src/completion.c Outdated Show resolved Hide resolved
@mysterywolf mysterywolf added the +1 Agree +1 label May 30, 2021
src/ipc.c Outdated Show resolved Hide resolved
@mysterywolf mysterywolf added +1 Agree +1 and removed +1 Agree +1 labels Jun 1, 2021
@Guozhanxin
Copy link
Member Author

@enkiller @jesven 看着没问题的话,+个1啊

@Guozhanxin Guozhanxin changed the title add RT_DEBUG_SCHEDULER_AVAILABLE check. [WIP] add RT_DEBUG_SCHEDULER_AVAILABLE check. Jun 24, 2021
@Guozhanxin Guozhanxin marked this pull request as draft June 24, 2021 02:45
@mysterywolf mysterywolf removed the +1 Agree +1 label Jul 26, 2021
@Guozhanxin Guozhanxin marked this pull request as ready for review January 26, 2022 08:36
@Guozhanxin Guozhanxin changed the title [WIP] add RT_DEBUG_SCHEDULER_AVAILABLE check. add RT_DEBUG_SCHEDULER_AVAILABLE check. Jan 26, 2022
@Guozhanxin
Copy link
Member Author

多了1k的rom占用,有些bsp编译不过了。。。

include/rtdebug.h Outdated Show resolved Hide resolved
src/ipc.c Outdated Show resolved Hide resolved
@Guozhanxin Guozhanxin added the +1 Agree +1 label Jan 28, 2022
@mysterywolf mysterywolf added the +2 Agree +2 label Jan 28, 2022
@Guozhanxin Guozhanxin merged commit 580194f into RT-Thread:master Jan 28, 2022
@thewon86
Copy link
Contributor

thewon86 commented Feb 9, 2022

https://club.rt-thread.org/ask/question/434519.html
https://club.rt-thread.org/ask/question/434558.html

开启内存堆后,main 线程就切换成动态创建了,这样就出现了在调度器启动前调用 malloc 的行为,进而会调用 rt_sem_take

/* parameter check */
RT_ASSERT(event != RT_NULL);
RT_ASSERT(rt_object_get_type(&event->parent.parent) == RT_Object_Class_Event);

/* current context checking */
RT_DEBUG_SCHEDULER_AVAILABLE(RT_TRUE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

郭老师,这个位置是RT_TRUE还是timeout != 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important +1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants