-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler flags issue #4953
Closed
Closed
Fix compiler flags issue #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCFLAGS is used by gcc and g++ compiler. So CFLAGS should be used for gcc to avoid passing gcc flags to g++.
CCFLAGS += ' -std=c99' |
这么改的话,开启c++是不是会有问题啊,感觉后面ci又要加上c++的测试了😂 |
如果rtconfig.py的gcc编译是这样写的就没问题(c++的std选项可以没有) |
Closed
您好,这个pr有冲突了,您有时间的话就解决一下,解决之后就可以合并了。 |
由于作者长期未回复,该 PR 已重新提交:#5171 |
作者还在睡觉😂 现在是欧洲凌晨 |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCFLAGS is used by gcc and g++ compiler. So CFLAGS should be used for gcc to avoid passing gcc flags to g++.
拉取/合并请求描述:(PR description)
[
Fix the wrong compiler flags for gcc.
CCFLAGS is general options that are passed to the C and C++ compilers. CFLAGS should should be used for gcc as it's the options that are passed to the C compiler only.
Has been tested on stm32 bsp.
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up