Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler flags issue #4953

Closed
wants to merge 1 commit into from
Closed

Conversation

JcZou
Copy link
Contributor

@JcZou JcZou commented Aug 19, 2021

CCFLAGS is used by gcc and g++ compiler. So CFLAGS should be used for gcc to avoid passing gcc flags to g++.

拉取/合并请求描述:(PR description)

[
Fix the wrong compiler flags for gcc.

CCFLAGS is general options that are passed to the C and C++ compilers. CFLAGS should should be used for gcc as it's the options that are passed to the C compiler only.

Has been tested on stm32 bsp.
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [*] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [*] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [*] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [*] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [*] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [*] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [*] 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • [*] 本拉取/合并符合RT-Thread代码规范 This PR complies with RT-Thread code specification

CCFLAGS is used by gcc and g++ compiler. So CFLAGS should be used for
gcc to avoid passing gcc flags to g++.
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2021

CLA assistant check
All committers have signed the CLA.

@mysterywolf
Copy link
Member

#2855

@JcZou
Copy link
Contributor Author

JcZou commented Aug 21, 2021

CCFLAGS += ' -std=c99'
CXXFLAGS += ' -std=c++14'
最终的g++的flag将是两者相加, g++将报无法识别'-std=c99的警告'

@Guozhanxin
Copy link
Member

Guozhanxin commented Aug 21, 2021

这么改的话,开启c++是不是会有问题啊,感觉后面ci又要加上c++的测试了😂

@JcZou
Copy link
Contributor Author

JcZou commented Aug 24, 2021

这么改的话,开启c++是不是会有问题啊,感觉后面ci又要加上c++的测试了😂

如果rtconfig.py的gcc编译是这样写的就没问题(c++的std选项可以没有)
CXXFLAGS = CFLAGS
CFLAGS += ' -std=c99'
CXXFLAGS += ' -std=c++14'

@Guozhanxin Guozhanxin added the in progress PR/issue in progress. label Sep 1, 2021
@mysterywolf mysterywolf removed the in progress PR/issue in progress. label Oct 9, 2021
@Guozhanxin
Copy link
Member

您好,这个pr有冲突了,您有时间的话就解决一下,解决之后就可以合并了。

@Guozhanxin Guozhanxin added the fix_for_conflicting Please fix conflicting files. label Oct 14, 2021
@liukangcc
Copy link
Member

liukangcc commented Oct 14, 2021

由于作者长期未回复,该 PR 已重新提交:#5171

@liukangcc liukangcc closed this Oct 14, 2021
@mysterywolf
Copy link
Member

作者还在睡觉😂 现在是欧洲凌晨

@liukangcc liukangcc mentioned this pull request Dec 17, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix_for_conflicting Please fix conflicting files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants