[Netif] Fix the eth_tx_msg protection #5045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ethernetif use semaphore netif->tx_ack to protect the local variable
struct eth_tx_msg msg
in functionethernetif_linkoutput
. But thefunction could be called in multiple context: LwIP "tcpip" thread, "erx"
thread(on linkup) and any user thread that call
udp_sendto
. So theglobal semaphore protection is not sufficient. It could only wakeup the
top priority waiting thread instead of the thread that owns the
msg
and may result the
msg
next in the mailbox got destructed.So to use a
rt_completion
within thestruct eth_tx_msg
andsynchronize on that. This could deal the ownership issue in an easy way.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up