Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dfs] remove dfs_select.h and dfs_poll.h #5199

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[dfs] remove dfs_select.h and dfs_poll.h #5199

merged 1 commit into from
Oct 27, 2021

Conversation

mysterywolf
Copy link
Member

拉取/合并请求描述:(PR description)

[

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin
Copy link
Member

改动有点大了,感觉有不少软件包要报错,建议稍晚一些合并。等软件包测试平台可以编译所以的软件包,并给出测试报告之后再合并

@Guozhanxin Guozhanxin added the Status: waiting for test Waiting test for this PR. label Oct 18, 2021
@mysterywolf
Copy link
Member Author

mysterywolf commented Oct 19, 2021

希望能在4.0.5发布之前完成,4.0.4完成了对libc的规范化,4.0.5将完成对dfs的规范化。

@Guozhanxin
Copy link
Member

已经可以跑了,下午看下整体测试结果

@Guozhanxin
Copy link
Member

Guozhanxin commented Oct 27, 2021

测过了,这两个编不过。后面需要处理。

@Guozhanxin Guozhanxin merged commit 3f4eead into RT-Thread:master Oct 27, 2021
@mysterywolf mysterywolf deleted the removeselectpoll branch October 27, 2021 06:01
@mysterywolf
Copy link
Member Author

不着急改,过些阶段还要把dfs_posix.h也删掉,一起再改。

@xiangxistu
Copy link
Member

dfs_posix.c, dfs_select.h, dfs_poll.h 这些去掉后,替换为什么呢?
引用标准接口吗?

我看 wiznet 里面,把 dfs_poll.h 替换为 poll.h 貌似就可以了

@mysterywolf
Copy link
Member Author

对的 完全按照unix标准接口来,dfs_xxxx.h的存在是因为在过去rtt的unix兼容性还不是很完善,经过我一年的努力,现在这部分的定义以及头文件已经完全按照unix/linux的来了。

@mysterywolf
Copy link
Member Author

#5230 (comment)

@Guozhanxin
Copy link
Member

Guozhanxin commented Oct 28, 2021

满老师,下次把这两个文件再提交上来吧,不过要加上warning提示。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Status: waiting for test Waiting test for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants