[component][mpu] [update] memory protect unit abstract layer. #5379

liukangcc · 2021-12-14T09:10:53Z

拉取/合并请求描述：(PR description)

[

描述

MAL (mpu abstract layer) 是 rt-thread 官方基于 Memory Protect Unit (MPU) 做的一款用于内存保护的抽象层组件。

作用

内存保护单元（MPU），提供了内存区域保护功能。通过 MPU，可以使程序更具健壮性，提高嵌入式系统的稳定性，使系统更加安全。通过使用 MPU 组件能使 RT-Thread 操作系统在进军军工、医疗、汽车等行业更具竞争力。MAL 组件具有以下特性：

线程堆栈溢出检测
内存隔离，某一线程使用的内存区域，其他线程禁止访问
为每个线程设定不同的区域的内存的访问权限

测试

已在 ART-Pi 上测试完成
]

以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
本拉取/合并请求代码是高质量的 Code in this PR is of high quality
本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Guozhanxin · 2021-12-14T09:52:32Z

include/rtdef.h

+
+struct rt_mal
+{
+    rt_uint16_t index;


这个作用是什么，会不会非对齐

BernardXiong · 2021-12-15T01:25:48Z

components/mal/Kconfig

@@ -0,0 +1,33 @@
+menu "MPU abstraction layer"


Is mal here? Please discuss.

这个什么意思呢，是名字不好，还是放的位置不好？

mal这个名字直接放置于components下都会显得奇怪。或者放入到components/drivers目录下，或者定义一些公共的API接口，由不同的硬件架构进行实现，从而放到libcpu中。

Guozhanxin · 2021-12-21T10:17:50Z

libcpu/arm/cortex-m7/context_rvds.S

 HardFault_Handler    PROC
-MemManage_Handler


这个Handler在这里去掉了，如果不开mal是不是就报错了？

这里要考虑不开MAL的情况下，如果触发了异常，怎么处理

BernardXiong · 2022-01-21T13:53:14Z

从名字上来说，直接使用mpu应该会更直接

BernardXiong

请仔细考虑 & 设计

BernardXiong · 2022-01-21T13:56:49Z

components/mal/Kconfig

@@ -0,0 +1,33 @@
+menu "MPU abstraction layer"


mal这个名字直接放置于components下都会显得奇怪。或者放入到components/drivers目录下，或者定义一些公共的API接口，由不同的硬件架构进行实现，从而放到libcpu中。

BernardXiong · 2022-01-21T13:57:27Z

components/mal/Kconfig

+            default 2
+
+        config RT_MPU_REGIONS_NUMBER
+            int "Set mpu regions number" 


这个MPU是一份ARM only的实现吗？如果是这样，那么放入到components下是非常不适合的

是通用的实现，支持 ARM RISCV

BernardXiong · 2022-01-21T13:58:53Z

components/mal/arch/riscv/riscv_mal.c

+
+static rt_err_t _mpu_get_info(rt_thread_t thread, rt_uint32_t type, void *arg)
+{
+    return RT_EOK;


所有的risc-v实现都是空的？…… Please tag this PR as draft.

BernardXiong · 2022-01-21T14:00:16Z

libcpu/arm/cortex-m7/context_rvds.S

@@ -127,6 +127,9 @@ PendSV_Handler   PROC
    STR     r1, [r0]                ; update from thread stack pointer

 switch_to_thread
+	IMPORT  rt_mpu_table_switch


TAB/space ……

汇编.s .asm .S .a后缀也应该纳入ci格式检查

不过上次FreeRTOS那边曾经提到过一个问题，貌似有些编译器如果改成空格会出问题，所以需要format之后再实际编译测试一下才可以。

liukangcc added 2 commits December 14, 2021 16:21

[update] memory protect unit abstract layer.

84bc591

[update] mal

bbc3512

liukangcc requested review from enkiller and Guozhanxin December 14, 2021 09:31

Guozhanxin reviewed Dec 14, 2021

View reviewed changes

include/rtdef.h

struct rt_mal

{

rt_uint16_t index;

Copy link

Member

Guozhanxin Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个作用是什么，会不会非对齐

BernardXiong reviewed Dec 15, 2021

View reviewed changes

BernardXiong added the discussion This PR/issue needs to be discussed later label Dec 15, 2021

liukangcc mentioned this pull request Dec 21, 2021

v4.1.0 特性征集与讨论 | v4.1.0 discussion #5342

Closed

24 tasks

Guozhanxin reviewed Dec 21, 2021

View reviewed changes

BernardXiong requested changes Jan 21, 2022

View reviewed changes

mysterywolf added the v5.0.0 label Aug 16, 2022

supperthomas changed the title ~~[update] memory protect unit abstract layer.~~ [component][mpu] [update] memory protect unit abstract layer. May 4, 2023

mysterywolf marked this pull request as draft May 13, 2023 04:31

mysterywolf removed the v5.0.0 label Aug 17, 2023

Guozhanxin closed this Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[component][mpu] [update] memory protect unit abstract layer. #5379

[component][mpu] [update] memory protect unit abstract layer. #5379

liukangcc commented Dec 14, 2021 •

edited

Loading

Guozhanxin Dec 14, 2021

BernardXiong Dec 15, 2021

Guozhanxin Jan 21, 2022

BernardXiong Jan 21, 2022

Guozhanxin Dec 21, 2021

Guozhanxin Jan 14, 2022

BernardXiong commented Jan 21, 2022

BernardXiong left a comment

BernardXiong Jan 21, 2022

BernardXiong Jan 21, 2022

liukangcc Jan 24, 2022

BernardXiong Jan 21, 2022

BernardXiong Jan 21, 2022

mysterywolf Jan 21, 2022

mysterywolf Aug 16, 2022

[component][mpu] [update] memory protect unit abstract layer. #5379

[component][mpu] [update] memory protect unit abstract layer. #5379

Conversation

liukangcc commented Dec 14, 2021 • edited Loading

拉取/合并请求描述：(PR description)

描述

作用

测试

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BernardXiong commented Jan 21, 2022

BernardXiong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liukangcc commented Dec 14, 2021 •

edited

Loading