-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] change ccflags to cflags #5411
Conversation
这个CFLAGS没啥问题 但是我在scons手册中没有发现LOCAL_CCFLAGS或者LOCAL_CFLAGS字样 |
确实。在 scons 手册中搜索不到 local_ccflags。所以,这里的 local_ccflags 可以删除掉了? |
LOCAL_CCFLAGS在building.py的local_group()函数中会将其加入CCFLAGS中
但是目前LOCAL_CFLAGS并没有其定义,所以编译的时候也并不会用到 |
另外,在之前的MR已经将CCFLAGS修改为CFLAGS,所以这里CCFLAGS实际上是C compiler的标志位,而C++ compiler的标志是CXXFLAGS
|
CCFLAGS -> 不区分C/C++ 都设置 建议增加LOCAL_CXXFLAGS LOCAL_CFLAGS |
96a11e4
to
32a827a
Compare
拉取/合并请求描述:(PR description)
[
这段方括号里的内容是您必须填写并替换掉的,否则PR不可能被合并。方括号外面的内容不需要修改,但请仔细阅读。
The content in this square bracket must be filled in and replaced, otherwise, PR can not be merged. The contents outside square brackets need not be changed, but please read them carefully.
请在这里填写您的PR描述,可以包括以下之一的内容:为什么提交这份PR;解决的问题是什么,你的解决方案是什么;
Please fill in your PR description here, which can include one of the following items: why to submit this PR; what is the problem solved and what is your solution;
并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested.
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up