-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lwip] integrate lwip porting layer #5606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [modify] extract the common files for different version about lwip. * [update] the initialization logic of lwIP.
24 tasks
This PR is ready to review! |
Guozhanxin
approved these changes
Feb 23, 2022
测试了下,没问题 |
Guozhanxin
reviewed
Feb 23, 2022
QIANWC
pushed a commit
to QIANWC/rt-thread
that referenced
this pull request
Feb 24, 2022
* [lwip] integrate lwip porting layer * Lwip 通用文件梳理 (RT-Thread#2) * [modify] extract the common files for different version about lwip. * [update] the initialization logic of lwIP. * 整理源码结构 * ethernetif 头文件 ""改为<> * 整理代码 * add macro definition "RT_USING_DEVICE_IPC". * [update] mandatory selected "RT_USING_DEVICE_IPC". * [modify] compile error for lost "lwip/init.h" Co-authored-by: xiangxistu <[email protected]> Co-authored-by: liuxianliang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
本PR由 @xiangxistu 和 @mysterywolf 共同完成
https://github.com/mysterywolf/rt-thread/tree/lwip%3Dport/components/net/lwip/port
以下内容为贤良在 mysterywolf#2 中的comment:
已经在 stm32f407-atk-explorer 上测试通过。
注意
仍然存在的问题:
lwip-1.4.1 上的 ping 问题未修复,上个版本也有类似问题,该问题与此次 PR 无关。
所有报文都能发出<发出错误报文也是发出,判断不是协议栈不运行的问题>;ICMP 报文能正常收发,ping lwip1.4.1 所在的 IP
地址也能收到回复,但是 ping 出时无法接收到回复。该问题与 dst 地址在报文中填写错误有关, DNS 服务正常,UDP 服务正常, TCP 客户端, TCP服务器测试正常。
TCP 重发次数过多
【逻辑正常,能连接,发送,接收,但有多次数据包重发的问题】
以上问题不属于本次 PR 的解决内容,会有后续 PR 处理该问题。
已经修改的问题:
在以前的版本中,flags 定义不准确,netdev.h 与 netif.h 中的 flags 宏冲突。现已经修改正常。
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up