Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools]keil.py Distinguish LOCAL_CFLAGS/LOCAL_CXXFLAGS, refine file c… #5694

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

Guozhanxin
Copy link
Member

@Guozhanxin Guozhanxin commented Mar 21, 2022

…ontrol

拉取/合并请求描述:(PR description)

[
fixed LOCAL_CCFLAGS not work at keil.
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin
Copy link
Member Author

将 local_xxx 的配置作用在单独的文件上,以区分同一个group下的c/cpp文件。

@mysterywolf mysterywolf added +1 Agree +1 in progress PR/issue in progress. and removed in progress PR/issue in progress. labels Mar 21, 2022
@mysterywolf
Copy link
Member

已经在RTduino软件包验证通过 测试标明:

  1. 本次修改已经解决了LOCAL中无法对某组进行设置特定flag的问题
  2. C++文件不能使用 --c99 这个flag,这个是keil自己的问题,C文件是可以使用的。需要使用LOCAL_CFLAGS单独设置--c99

related: RTduino/RTduino@47d4d07

@Guozhanxin Guozhanxin merged commit ce51d0b into RT-Thread:master Mar 22, 2022
@mysterywolf
Copy link
Member

经过手动选择c99的复选框也会发现,如果是c++文件,即使勾选了c99的复选框,下面的flag也没有任何变化,即在keil下,c++文件中c99选项是无效的,如果强行手动增加--c99的flag,会导致文件大面积报错。

可以看出,部分编译器对c99的支持属于支持了一半留了一半,因此,需要对RT-Thread代码进行筛查,尽可能降低对c99的使用要求,以防止出现不必要的麻烦。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants