[DFS] add Kconfig for dfs-v2.0 #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mysterywolf
requested changes
Apr 3, 2023
mysterywolf
requested changes
Apr 4, 2023
| CPPPATH = [cwd + "/include"] | ||
| group = [] | ||
|
|
||
| if GetDepend('RT_USING_DFS') and not GetDepend('RT_USING_DFS_V2'): |
There was a problem hiding this comment.
Suggested change
| if GetDepend('RT_USING_DFS') and not GetDepend('RT_USING_DFS_V2'): | |
| if GetDepend('RT_USING_DFS_V1'): |
There was a problem hiding this comment.
得刷工程，那就不用改了，我没啥问题了，可以先合进去，后面细节可以边推进边改 Sconscript那里改改 我就没啥问题了
| # The set of source files associated with this SConscript file. | ||
| src = [] | ||
| cwd = GetCurrentDir() | ||
| CPPPATH = [cwd + "/include"] |
There was a problem hiding this comment.
尽量采用os.path.join代替直接拼接带/字符串的路径，因为不同操作系统路径分隔符不一样，os.path.join可以自动处理不同操作系统的问题，之前遇到过类似的问题。
Suggested change
| CPPPATH = [cwd + "/include"] | |
| CPPPATH = [os.path.join(cwd, 'include')] |
| CPPPATH = [cwd + "/include"] | ||
| group = [] | ||
|
|
||
| if GetDepend('RT_USING_DFS') and GetDepend('RT_USING_DFS_V2'): |
There was a problem hiding this comment.
Suggested change
| if GetDepend('RT_USING_DFS') and GetDepend('RT_USING_DFS_V2'): | |
| if GetDepend('RT_USING_DFS_V2'): |
| # The set of source files associated with this SConscript file. | ||
| src = [] | ||
| cwd = GetCurrentDir() | ||
| CPPPATH = [cwd + "/include"] |
mysterywolf
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
合并DFS v2.0相关的Kconfig，其他部分陆续合并到dfs v2中，同时具备一定的兼容性。
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up