Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fal] Add blocks mechanism to fal. #8252

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

Guozhanxin
Copy link
Member

@Guozhanxin Guozhanxin commented Nov 13, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

原来的fal对 flash不均匀分布的flash不友好,比如stm32. 明明是一块地址连续的 flash,需要注册出来3个flash设备,fal的分区还不能跨 flash 使用。导致app分区只能放在 128K起始的地址上,造成flash的浪费

你的解决方案是什么 (what is your solution)

为 fal 添加 blocks 机制,支持添加特殊的 block 定义。
使用方式如下,添加了具体的flash的blocks定义,4个16K的blk,1个64K,7个128K。

const struct fal_flash_dev stm32_onchip_flash =
{
    "onchip",
    STM32_FLASH_START_ADRESS,
    (1024 * 1024),
    (16 * 1024),
    {
        NULL,
        fal_flash_read,
        fal_flash_write,
        fal_flash_erase,
    },
    8,
    {
        { .size = 0x4000, .count = 4 },
        { .size = 0x10000, .count = 1 },
        { .size = 0x20000, .count = 7 },
        { 0 },
    },
};

在什么测试环境下测试通过 (what is the test environment)

在 星火1号上测试通过。

image
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin Guozhanxin marked this pull request as draft November 13, 2023 09:53
@Guozhanxin Guozhanxin marked this pull request as ready for review November 13, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants