Fix sources clone #373
Merged
Fix sources clone #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTimothyEdwards
approved these changes
May 11, 2023
|
Pulled and merged. |
donn
added a commit
to donn/open_pdks
that referenced
this pull request
May 8, 2024
RTimothyEdwards#373, specifically commit `db529a71335176db64b18b98228fdd7f03a8c24b` fixed an issue where the shell commands inside `gf180mcu/Makefile.in` were not properly chained for some make productions, causing the branch commit to be dropped, however, the same issue persisted for `sky130`. This caused builds to be non-reproducible for `sky130` where the Makefile would *always* grab the latest for each repo. The result was `--with-reference` never worked for sky130. This also adds an additional print to `scripts/download.sh` just to verify the commit is correctly propagated to the `git clone` commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
; \to chain commands to be able to reuse the shell variable created earlier. Each line of a make recipe is a separate shell instance.${FD_PV_COMMIT}, and similar variables, to use the shell variable created in the recipedownload.sh, if git clone --branch fails, attempt to git clone and checkout - for commits.